Skip to content

ref(flex) run codemod on orphaned files#115393

Merged
natemoo-re merged 6 commits into
masterfrom
jb/codemod/flex-orphaned-05-12
May 13, 2026
Merged

ref(flex) run codemod on orphaned files#115393
natemoo-re merged 6 commits into
masterfrom
jb/codemod/flex-orphaned-05-12

Conversation

@JonasBa
Copy link
Copy Markdown
Member

@JonasBa JonasBa commented May 12, 2026

Re-running the flex codemod on some orphaned files (it's been a while since the last time we ran it)

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.51%

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit dacead3. Configure here.

Comment thread static/app/components/roleSelectControl.tsx
Comment thread static/app/components/customResolutionModal.tsx Outdated
Comment thread static/gsAdmin/views/home.tsx
Rename local Container definitions that shadow the imported Container
from @sentry/scraps/layout, fixing TS2440 and TS2322 errors in tsgo.

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the cursor comments are all legit here! Otherwise only saw one thing.

Comment thread static/app/components/contentSliderDiff/index.tsx Outdated
- Use minHeight prop instead of style attribute in contentSliderDiff
- Add display inline-block to Container as span in customResolutionModal
- Add display block to Container as label elements in gsAdmin/views/home

Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
Comment thread static/app/components/roleSelectControl.tsx Outdated
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor didn't seem to trigger but it's a tiny change!

@natemoo-re natemoo-re enabled auto-merge (squash) May 13, 2026 22:11
@natemoo-re natemoo-re merged commit 8dd445c into master May 13, 2026
73 checks passed
@natemoo-re natemoo-re deleted the jb/codemod/flex-orphaned-05-12 branch May 13, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants